Make pasting inline into <script> tag possible #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -370,7 +370,7 @@ | |||
| iframe_doc.open(); | |||
|
|
|||
| // Set document.domain for the Iframe document as well, if necessary. | |||
| domain && iframe_doc.write( '<script>document.domain="' + domain + '"</script>' ); | |||
| domain && iframe_doc.write( '<scr' + 'ipt>document.domain="' + domain + '"</scr' + 'ipt>' ); | |||
There was a problem hiding this comment.
As discussed on IRC, prefer \x3script to the concatenation
The browser interprets the occurrence of the literal "</script>" inside of the body of a script tag as the end of the script, so the leading "<" must be escaped by replacing it with \x3c
gabrielschulhof
pushed a commit
to jquery-archive/jquery-mobile
that referenced
this pull request
Apr 8, 2014
Grab the version of jquery.hashchange.js that includes gseguin/jquery-hashchange#1 which will cause the built library to be inline-able. Fixes gh-7300
gabrielschulhof
pushed a commit
to jquery-archive/jquery-mobile
that referenced
this pull request
Apr 8, 2014
Grab the version of jquery.hashchange.js that includes gseguin/jquery-hashchange#1 which will cause the built library to be inline-able. Fixes gh-7300 (cherry picked from commit 400c856)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re jquery-archive/jquery-mobile#7300