-
Notifications
You must be signed in to change notification settings - Fork 7
Add support for HTML & XML source #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 11 13 +2
Lines 250 258 +8
=====================================
+ Hits 250 258 +8
Continue to review full report at Codecov.
|
|
@shinnn |
|
What do you mean by "empty files"? At least the following code doesn't throw any errors. const postcss = require('postcss');
const result = postcss().process('', {
syntax: require('postcss-syntax'),
from: '/path/to/example.xml'
}); |
Empty string source.
const postcss = require('postcss');
const result = postcss().process('', {
syntax: require('postcss-syntax'),
// empty source `*.svg` file will berak postcss-syntax
from: '/path/to/example.svg'
}); |
|
Post #26 (comment) first. #26 (comment) was extremely confusing to me.
Could you at least support all the XML-related extensions you know currently? |
|
In addition to XSL, other XML is actually not supported by us because they are not style files. I found that there are about 100+ extensions for XML format, but in fact we only support one (XSL). |
shinnn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough.
d47c713 to
9a9deb0
Compare
|
@gucong3000 What is blocking this from being merged? |
Some integration test runs failed:
|
|
Replace with #28 |

cssfor other unknown file extensionstylelint/stylelint#3328 (comment)