Post-processor export Parallels macvm#106
Merged
lbajolet-hashicorp merged 1 commit intohashicorp:mainfrom Jan 9, 2024
Merged
Conversation
Make the post-processor able to create vagrant box from M1 macOS images.
|
|
lbajolet-hashicorp
approved these changes
Jan 9, 2024
Contributor
lbajolet-hashicorp
left a comment
There was a problem hiding this comment.
Hi @SztivT,
Thanks for this contribution!
I would argue that the post-processor should fail when no file has been extracted (which does not seem to be the case surprisingly), but this can be fixed aside from your contribution.
I'll open a PR for that shortly, in the meantime I'll merge this once tests are green.
Thanks again!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for the change
packer-plugin-parallelssupports building of m1 macOS virtual machines, alas, without this change the default workflow succeeds with an invalid box, not containing the VM.What changed
Rephrased regex pattern for vm file path including
pvmandmacvmin a search group.