parallels: error when no VM file found in source#107
Merged
Conversation
nywilken
approved these changes
Jan 9, 2024
Contributor
nywilken
left a comment
There was a problem hiding this comment.
LGTM to me I left a single nit.
nywilken
reviewed
Jan 9, 2024
Contributor
nywilken
left a comment
There was a problem hiding this comment.
It looks like the mocked test needs to be updated to contain a valid file
--- FAIL: TestPostProcessorPostProcess_vagrantfileUserVariable (0.01s)
post-processor_test.go:265: err: No VM file found in source artifact
3b41b4d to
2fac2c3
Compare
Contributor
Author
|
@nywilken regarding the failing test, I opted to add some mocked file hierarchy for the parallels test, and added another one to ensure we do fail when no files are present in the artifact. To be sure if you can do a quick second peek at the code that'd be great, and we can merge if that looks good to you |
The post-processor, when consuming a parallels artifact, checks for the presence of a pvm or macvm file from the files of the artifact received, and copies it in the output box for vagrant to use later. However, if the artifact does not contain a compatible file, the post-processor does not error, and instead returns a success, leading to an unusable box being produced. To avoid this, we count the files copied, and if none were, the box will be unusable, so the post-processor errors now.
2fac2c3 to
40abc55
Compare
nywilken
approved these changes
Jan 16, 2024
Contributor
nywilken
left a comment
There was a problem hiding this comment.
I rebased and rerolled this change a little to add the test cases to the parallels_test.go file since they are Parallels specific.
? github.com/hashicorp/packer-plugin-vagrant [no test files]
testing: warning: no tests to run
PASS
ok github.com/hashicorp/packer-plugin-vagrant/builder/vagrant (cached) [no tests to run]
? github.com/hashicorp/packer-plugin-vagrant/version [no test files]
=== RUN TestPostProcessorPostProcessParallels
2024/01/16 16:53:33 ui: Creating a dummy Vagrant box to ensure the host system can create one correctly
2024/01/16 16:53:33 Turning dir into box: /var/folders/jd/zhl6kpsn1156cmqdyttt22xm0000gp/T/packer3976304713 => /var/folders/jd/zhl6kpsn1156cmqdyttt22xm0000gp/T/box-1323631034.box
2024/01/16 16:53:33 Compressing with gzip compression level: -1
2024/01/16 16:53:33 Skipping directory '/var/folders/jd/zhl6kpsn1156cmqdyttt22xm0000gp/T/packer3976304713' for box '/var/folders/jd/zhl6kpsn1156cmqdyttt22xm0000gp/T/box-1323631034.box'
2024/01/16 16:53:33 Box add: '/var/folders/jd/zhl6kpsn1156cmqdyttt22xm0000gp/T/packer3976304713/metadata.json' to '/var/folders/jd/zhl6kpsn1156cmqdyttt22xm0000gp/T/box-1323631034.box'
2024/01/16 16:53:33 ui: Creating Vagrant box for 'parallels' provider
2024/01/16 16:53:33 ui: Copying: /var/folders/jd/zhl6kpsn1156cmqdyttt22xm0000gp/T//1055054597.pvm/3873643601
2024/01/16 16:53:33 ui: Copying: /var/folders/jd/zhl6kpsn1156cmqdyttt22xm0000gp/T//1055054597.pvm/255380389
2024/01/16 16:53:33 ui: Using custom Vagrantfile: /var/folders/jd/zhl6kpsn1156cmqdyttt22xm0000gp/T/packer122144398
2024/01/16 16:53:33 Turning dir into box: /var/folders/jd/zhl6kpsn1156cmqdyttt22xm0000gp/T/packer830734517 => packer__parallels_arm64.box
2024/01/16 16:53:33 Compressing with gzip compression level: -1
2024/01/16 16:53:33 Skipping directory '/var/folders/jd/zhl6kpsn1156cmqdyttt22xm0000gp/T/packer830734517' for box 'packer__parallels_arm64.box'
2024/01/16 16:53:33 Skipping directory '/var/folders/jd/zhl6kpsn1156cmqdyttt22xm0000gp/T/packer830734517/1055054597.pvm' for box 'packer__parallels_arm64.box'
2024/01/16 16:53:33 Box add: '/var/folders/jd/zhl6kpsn1156cmqdyttt22xm0000gp/T/packer830734517/1055054597.pvm/255380389' to 'packer__parallels_arm64.box'
2024/01/16 16:53:33 ui: Compressing: 1055054597.pvm/255380389
2024/01/16 16:53:33 Box add: '/var/folders/jd/zhl6kpsn1156cmqdyttt22xm0000gp/T/packer830734517/1055054597.pvm/3873643601' to 'packer__parallels_arm64.box'
2024/01/16 16:53:33 ui: Compressing: 1055054597.pvm/3873643601
2024/01/16 16:53:33 Box add: '/var/folders/jd/zhl6kpsn1156cmqdyttt22xm0000gp/T/packer830734517/Vagrantfile' to 'packer__parallels_arm64.box'
2024/01/16 16:53:33 ui: Compressing: Vagrantfile
2024/01/16 16:53:33 Box add: '/var/folders/jd/zhl6kpsn1156cmqdyttt22xm0000gp/T/packer830734517/metadata.json' to 'packer__parallels_arm64.box'
2024/01/16 16:53:33 ui: Compressing: metadata.json
--- PASS: TestPostProcessorPostProcessParallels (0.01s)
=== RUN TestPostProcessorPostProcessParallels_NoFileErrorOnCopy
2024/01/16 16:53:33 ui: Creating a dummy Vagrant box to ensure the host system can create one correctly
2024/01/16 16:53:33 Turning dir into box: /var/folders/jd/zhl6kpsn1156cmqdyttt22xm0000gp/T/packer4246976573 => /var/folders/jd/zhl6kpsn1156cmqdyttt22xm0000gp/T/box-2869865802.box
2024/01/16 16:53:33 Compressing with gzip compression level: -1
2024/01/16 16:53:33 Skipping directory '/var/folders/jd/zhl6kpsn1156cmqdyttt22xm0000gp/T/packer4246976573' for box '/var/folders/jd/zhl6kpsn1156cmqdyttt22xm0000gp/T/box-2869865802.box'
2024/01/16 16:53:33 Box add: '/var/folders/jd/zhl6kpsn1156cmqdyttt22xm0000gp/T/packer4246976573/metadata.json' to '/var/folders/jd/zhl6kpsn1156cmqdyttt22xm0000gp/T/box-2869865802.box'
2024/01/16 16:53:33 ui: Creating Vagrant box for 'parallels' provider
parallels_test.go:117: failed as expected: No VM file found in source artifact
--- PASS: TestPostProcessorPostProcessParallels_NoFileErrorOnCopy (0.00s)
PASS
ok github.com/hashicorp/packer-plugin-vagrant/post-processor/vagrant 0.305s
testing: warning: no tests to run
PASS
ok github.com/hashicorp/packer-plugin-vagrant/post-processor/vagrant-cloud (cached) [no tests to run]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The post-processor, when consuming a parallels artifact, checks for the presence of a pvm or macvm file from the files of the artifact received, and copies it in the output box for vagrant to use later. However, if the artifact does not contain a compatible file, the post-processor does not error, and instead returns a success, leading to an unusable box being produced.
To avoid this, we count the files copied, and if none were, the box will be unusable, so the post-processor errors now.