Merged
Conversation
Contributor
nywilken
commented
Jan 17, 2024
- version: Cut release 1.1.2
- version: prepare for 1.1.3 dev
lbajolet-hashicorp
approved these changes
Jan 17, 2024
version/version.go
Outdated
| // (empty string) then it means that it is a final release. Otherwise, this | ||
| // is a pre-release such as "dev" (in development), "beta", "rc1", etc. | ||
| VersionPrerelease = "dev" | ||
| VersionPrerelease = "" |
Contributor
There was a problem hiding this comment.
I would suggest updating the README for the plugin so the exerpt for required_plugins shows the latest version as 1.1.2, but this is optional.
Contributor
Author
There was a problem hiding this comment.
Ah good point. I will push that and merge. Thanks. I'll do this for the other two plugins as well.
Contributor
Author
There was a problem hiding this comment.
Actually it looks like they may be out of sync a bit. I will fast follow with a different PR since the integration install docs use ~> 1 for the version string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.