Allow execute calls to receive extra env vars#51
Open
electrofelix wants to merge 1 commit intohashicorp:mainfrom
Open
Allow execute calls to receive extra env vars#51electrofelix wants to merge 1 commit intohashicorp:mainfrom
electrofelix wants to merge 1 commit intohashicorp:mainfrom
Conversation
With acceptance tests it can be useful to be able to override or set a specific env var when executing a call at a single point in a test example. Instead of duplicating or moving with_temp_env() from the unit tests, it is easier to ensure isolation of tests by avoiding modify of ENV directly and instead allow the tests to configure the environment for the process launched.
fefe256 to
e52e00c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With acceptance tests it can be useful to be able to override or set a
specific env var when executing a call at a single point in a test
example.
Instead of duplicating or moving with_temp_env() from the unit tests, it
is easier to ensure isolation of tests by avoiding modify of ENV
directly and instead allow the tests to configure the environment for
the process launched.