Skip to content

subprocess: Fix the argument delegation with Ruby 3.0#56

Closed
legal90 wants to merge 1 commit intohashicorp:mainfrom
legal90:fix-ruby-3
Closed

subprocess: Fix the argument delegation with Ruby 3.0#56
legal90 wants to merge 1 commit intohashicorp:mainfrom
legal90:fix-ruby-3

Conversation

@legal90
Copy link
Contributor

@legal90 legal90 commented Mar 22, 2023

This PR fixes the following error which currently happens on Ruby 3.0:

provider/parallels/disk/basic
  it should behave like provider/disk/basic
    configures storage mediums
      Execute: vagrant box add box /Users/legal/Workspace/vagrant-parallels/boxes/centos-7.8.box
      Execute: vagrant destroy --force
      configures storage mediums (FAILED - 1)

Failures:

  1) provider/parallels/disk/basic it should behave like provider/disk/basic configures storage mediums
     Got 0 failures and 2 other errors:
     Shared Example Group: "provider/disk/basic" called from

     1.1) Failure/Error: raise ArgumentError, message

          ArgumentError:
            A list of notify subscriptions must be given if a block is given
          # /Users/legal/.rbenv/versions/3.0.4/lib/ruby/gems/3.0.0/bundler/gems/vagrant-spec-708be5c53ea1/lib/vagrant-spec/subprocess.rb:52:in `execute'
          # /Users/legal/.rbenv/versions/3.0.4/lib/ruby/gems/3.0.0/bundler/gems/vagrant-spec-708be5c53ea1/lib/vagrant-spec/subprocess.rb:28:in `execute'
          # /Users/legal/.rbenv/versions/3.0.4/lib/ruby/gems/3.0.0/bundler/gems/vagrant-spec-708be5c53ea1/lib/vagrant-spec/acceptance/isolated_environment.rb:62:in `execute'
          # /Users/legal/.rbenv/versions/3.0.4/lib/ruby/gems/3.0.0/bundler/gems/vagrant-spec-708be5c53ea1/lib/vagrant-spec/acceptance/rspec/context.rb:54:in `execute'
          # /Users/legal/.rbenv/versions/3.0.4/lib/ruby/gems/3.0.0/bundler/gems/vagrant-spec-708be5c53ea1/lib/vagrant-spec/acceptance/rspec/context.rb:61:in `assert_execute'
          # /Users/legal/.rbenv/versions/3.0.4/lib/ruby/gems/3.0.0/bundler/gems/vagrant-spec-708be5c53ea1/acceptance/disk/basic_spec.rb:14:in `block (2 levels) in <top (required)>'

The route cause is the way how Ruby 3.0 handle the argument delegation.
See more details in the section "Handling argument delegation" here: https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/

legal90 added a commit to Parallels/vagrant-parallels that referenced this pull request Mar 22, 2023
@legal90
Gemfile: Update dev dependencies
fedda4d 
- Pin `vagrant` to the latest release tag `v2.3.4`. Current `main` branch has unreleased changes which brakes our
acceptance tests. Ref: hashicorp/vagrant#13052 (comment)

- Pin `vagrant-spec` to a PR branch, which contains the fix for Ruby 3.0 runtime:
hashicorp/vagrant-spec#56
legal90 added a commit to Parallels/vagrant-parallels that referenced this pull request Mar 22, 2023
@legal90
Gemfile: Update dev dependencies
9ee6da3 
- Pin `vagrant` to the latest release tag `v2.3.4`. Current `main` branch has unreleased changes which brakes our
acceptance tests. Ref: hashicorp/vagrant#13052 (comment)

- Pin `vagrant-spec` to a PR branch, which contains the fix for Ruby 3.0 runtime:
hashicorp/vagrant-spec#56
@legal90 legal90 mentioned this pull request Mar 22, 2023
Merged
@legal90
Copy link
Contributor Author

legal90 commented Feb 15, 2024

Hi Vagrant team! Are you interested to get it merged?
cc @nodyhub, @vancluever

@legal90
Copy link
Contributor Author

legal90 commented May 20, 2025

No response for 2+ years. Closing this PR.

@legal90 legal90 closed this May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@legal90