Prevent acceptance context from clearing extra_env#9
Open
Sharpie wants to merge 1 commit intohashicorp:mainfrom
Open
Prevent acceptance context from clearing extra_env#9Sharpie wants to merge 1 commit intohashicorp:mainfrom
Sharpie wants to merge 1 commit intohashicorp:mainfrom
Conversation
Provider-specific contexts are usually included before the acceptance context. This meant that when acceptance defined `extra_env` to be an empty hash, any environment variables set by the provider context were lost. This patch removes the empty hash definition from acceptance and instead guards the use of `extra_env` with `defined?`.
Contributor
Author
|
@mitchellh Any thoughts about this? |
Contributor
Author
|
@mitchellh Ping again. Any objections to merging this patch? |
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provider-specific contexts are usually included before the acceptance context.
This meant that when acceptance defined
extra_envto be an empty hash, anyenvironment variables set by the provider context were lost.
This patch removes the empty hash definition from acceptance and instead guards
the use of
extra_envwithdefined?.