Skip to content

Get folder mount name#12281

Merged
soapy1 merged 1 commit intohashicorp:mainfrom
soapy1:smb-mount-name
Apr 13, 2021
Merged

Get folder mount name#12281
soapy1 merged 1 commit intohashicorp:mainfrom
soapy1:smb-mount-name

Conversation

@soapy1
Copy link
Contributor

@soapy1 soapy1 commented Apr 6, 2021

Copy link
Member

@chrisroberts chrisroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update the test for this by updating the allow mock to only match on the correct number of passed arguments.

@DanSibbernsen
Copy link

DanSibbernsen commented Apr 11, 2021

Hi! I'm relatively new to the Vagrant world. Would this fix also need to be incorporated into the Vagrant-Parallels provider's use of mount? Example here

If so, I can open a change request over there (I'm stuck on this issue too)

@soapy1
Copy link
Contributor Author

soapy1 commented Apr 12, 2021

@DanSibbernsen yep, I think you are right. That mount_name bit should look something like this smb capability. You can double check that this change is required by running vagrant 2.2.15 with the parallels plugin.

@soapy1 soapy1 merged commit dfc8cab into hashicorp:main Apr 13, 2021
@soapy1 soapy1 deleted the smb-mount-name branch April 13, 2021 18:57
@legal90
Copy link
Contributor

legal90 commented Apr 14, 2021

Thank you, @soapy1.
It's a bit unfortunate that the positional arguments passed to mount_name capability were changed in Vagrant 2.2.15 (by #12281). That was a breaking change for 3rd party plugins like vagrant-parallels, implementing this capability on their side. :(

We have to use some smelly hacks in order to work it around and keep the backward compatibility: https://github.com/Parallels/vagrant-parallels/pull/386/files

Hopefully, we can avoid such things in the future 👍

@ghost
Copy link

ghost commented May 14, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SMB mount broken since 2.2.15

4 participants