providers/virtualbox: cache VirtualBox version [GH-6468]#6552
Merged
providers/virtualbox: cache VirtualBox version [GH-6468]#6552
Conversation
Contributor
There was a problem hiding this comment.
Do we need a lock around this?
Contributor
Author
There was a problem hiding this comment.
Ah, VirtualBox doesn't parallelize, but lets just do it to avoid any issues in the future.
Contributor
|
LGTM |
mitchellh
added a commit
that referenced
this pull request
Nov 19, 2015
providers/virtualbox: cache VirtualBox version [GH-6468]
legal90
added a commit
to legal90/vagrant-parallels
that referenced
this pull request
Nov 23, 2015
Actually, Parallels Desktop version is not changing during the Vagrant run. So, we can cache it on the class level to speed up the execution and avoid extra `prlctl --version` calls. This is a port of upstream PR: hashicorp/vagrant#6552
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6468
Apparently just reading the VirtualBox version on some systems can be SUPER slow. Let's cache that as recommended in #6468 to speed that up since its unlikely to change.