Skip to content

Bump nokogiri dependency to the latest stable version#7833

Closed
joelhandwell wants to merge 1 commit intohashicorp:masterfrom
joelhandwell:nokogiri
Closed

Bump nokogiri dependency to the latest stable version#7833
joelhandwell wants to merge 1 commit intohashicorp:masterfrom
joelhandwell:nokogiri

Conversation

@joelhandwell
Copy link
Contributor

@joelhandwell joelhandwell commented Sep 27, 2016

ChefDK 0.18.26 released with Berkshelf 5.1.0 and embedded Ruby 2.3.1. To use Ruby 2.3.1 and berkshelf 5.1.0 together with vagrant-berkshelf plugin, vagrant-berkshelf plugin have to update nokogiri dependency to 1.6.8 because nokogiri 1.6.7.1 is not compatible with Ruby < 2.3 as following:

C:\oss\vagrant-berkshelf>gem install nokogiri -v '1.6.7.1'
WARNING:  You don't have c:\users\joel\appdata\local\chefdk\gem\ruby\2.3.0\bin in your PATH,
          gem executables will not run.
ERROR:  Error installing nokogiri:
        nokogiri requires Ruby version < 2.3, >= 1.9.2.

And when nokogiri 1.6.8 is set as dependency in vagrant-berkshelf Gemfile, following error is shown:

C:\oss\vagrant-berkshelf>bundle install
Your Gemfile lists the gem vagrant-berkshelf (>= 0) more than once.
You should probably keep only one of them.
While it's not a problem now, it could cause errors if you change the version of just one of them later.
Fetching git://github.com/mitchellh/vagrant.git
Fetching gem metadata from https://rubygems.org/
Fetching version metadata from https://rubygems.org/
Fetching dependency metadata from https://rubygems.org/
Resolving dependencies..........
Bundler could not find compatible versions for gem "nokogiri":
  In Gemfile:
    nokogiri (>= 1.6.8) x86-mingw32

    vagrant x86-mingw32 was resolved to 1.8.6.dev, which depends on
      nokogiri (= 1.6.7.1) x86-mingw32

Above error suggests nokogiri dependency needs to be upgraded in vagrant first, then vagrant-berkshelf can upgrade nokogiri dependency to 1.6.8, then ChefDK 0.18.26 can be used with vagrant-berkshelf plugin without following error:

C:\Users\Joel\test>vagrant up test
Bringing machine 'test' up with 'virtualbox' provider...
The Berkshelf version at "C:\\opscode\\chefdk\\embedded\\bin/berks.BAT" is invalid.
Vagrant Berkshelf requires ~> 4.0, but the current version is 5.1.0.

Please download and install the latest version of the ChefDK from:

    https://downloads.chef.io/chef-dk

and follow the installation instructions. Do not forget to add the ChefDK to
your PATH.

The environment of this context is Windows 10.

#6766, berkshelf/vagrant-berkshelf#305, berkshelf/vagrant-berkshelf#306 is related with this.

@chrisroberts chrisroberts added this to the 1.9 milestone Oct 5, 2016
@littlesnitch
Copy link

+1
Is important for us as well. We would appreciate this commit.

@joelhandwell
Copy link
Contributor Author

Closing this for #8571 covers

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants