Skip to content

Various Fixes with support for more attributes.#34

Closed
hasokeric wants to merge 8 commits intohighchartTable:masterfrom
hasokeric:master
Closed

Various Fixes with support for more attributes.#34
hasokeric wants to merge 8 commits intohighchartTable:masterfrom
hasokeric:master

Conversation

@hasokeric
Copy link

Ignore my Readme however :-)

@ratibus
Copy link
Contributor

ratibus commented Oct 3, 2012

Hi

Few comments about this PR :

  • you changed the licence from MIT to GPL. Blocker to merge this PR.
  • you changed the readme file to link to your fork. Blocker too.
  • this PR cannot be automatically merged. Blocker too.
  • you broke indentation.
  • you fix multiple unrelated issues within the same PR. I would prefer one PR by issue (or at least related issues). For example, for the moment, we do not want to provide a minified version of this plugin but we are interested in some other changes.

Please update this PR.

Regards.

@ratibus ratibus closed this Oct 18, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants