Skip to content

remove default value for the data-graph-yaxis-X-title-text attribute#48

Merged
agallou merged 1 commit intohighchartTable:masterfrom
agallou:remove-french-default-value
Oct 14, 2013
Merged

remove default value for the data-graph-yaxis-X-title-text attribute#48
agallou merged 1 commit intohighchartTable:masterfrom
agallou:remove-french-default-value

Conversation

@agallou
Copy link
Member

@agallou agallou commented Oct 12, 2013

The default value for the data-graph-yaxis-X-title-text attribute is "Valeur".

It should'nt be a french value. We can remove the default value (see #8).

People using the default value can do something like this for backward compatibility :

$('table.highchart').bind('highchartTable.beforeRender', function(event, highChartConfig) {
  $.each(highChartConfig.yAxis, function (index, value)   {
    value.title.text = value.title.text || 'Valeur';
  });
});

@ratibus
Copy link
Contributor

ratibus commented Oct 12, 2013

You should put your code example in the documentation :)

@agallou
Copy link
Member Author

agallou commented Oct 12, 2013

@ratibus i've made a PR for that (issue #49)

@ratibus
Copy link
Contributor

ratibus commented Oct 13, 2013

Perfect :)

agallou added a commit that referenced this pull request Oct 14, 2013
remove default value for the data-graph-yaxis-X-title-text attribute
@agallou agallou merged commit c60c1c5 into highchartTable:master Oct 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments