Skip to content

rich the information of package.json#79

Merged
agallou merged 1 commit intohighchartTable:masterfrom
pvnr0082t:update-package.json
Oct 5, 2016
Merged

rich the information of package.json#79
agallou merged 1 commit intohighchartTable:masterfrom
pvnr0082t:update-package.json

Conversation

@pvnr0082t
Copy link
Contributor

add some information for package.json

  • description
  • author
  • repository
  • keywords
  • homepage
  • license

@agallou
Copy link
Member

agallou commented Sep 24, 2016

Thanks for the PR.
Does this mean you need the package to be published on npm ?

package.json Outdated
"name": "highchartTable",
"version": "1.1.0",
"description": "This jQuery plugin provides a simple way to convert HTML data tables to Highcharts graphs.",
"author": "agallou",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is multiple contributors to the project. Could you change the author to "highchartTable Development Team (https://github.com/highchartTable/jquery-highchartTable-plugin/graphs/contributors)" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course. Author information updated. 👍

@pvnr0082t
Copy link
Contributor Author

Does this mean you need the package to be published on npm ?

It's up to you:smiley: . These information are necessary in cdnjs, so I just want to contribute to the upstream.

@agallou agallou merged commit a5d2f3e into highchartTable:master Oct 5, 2016
@agallou
Copy link
Member

agallou commented Oct 5, 2016

thanks @pvnr0082t

@pvnr0082t
Copy link
Contributor Author

@agallou No problem. 👊

@pvnr0082t pvnr0082t deleted the update-package.json branch October 5, 2016 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants