Fix a graphical bug in Firefox - Should fix #24#33
Merged
hojberg merged 3 commits intohojberg:masterfrom Aug 24, 2012
Merged
Conversation
Owner
|
Sweet! Could you add a test to that and i'll merge it in :) Thanks! |
add input checking in hexToRGB function
Contributor
Author
|
Hi, I added some tests for the hexToRGB function and a test for the _arrowCSS border color. |
Owner
|
Thanks! |
hojberg
added a commit
that referenced
this pull request
Aug 24, 2012
Fix a graphical bug in Firefox - Should fix #24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The graphical bug in Firefox was caused by the anti-aliasing between the colored border and the transparent one.
You can read more information on this 'issue' on this blog post from Chris Morgan: CSS's "transparent" may not be transparent, especially on diagonal borders
I resolved the issue by replacing transparent by the user-selected color with an alpha of 0. Transparent is still used for IE8 who do not know rgba().