Skip to content

Added Support for LESS and SCSS#36

Closed
nitinhayaran wants to merge 1 commit intohojberg:masterfrom
nitinhayaran:master
Closed

Added Support for LESS and SCSS#36
nitinhayaran wants to merge 1 commit intohojberg:masterfrom
nitinhayaran:master

Conversation

@nitinhayaran
Copy link

Currently cssarrowplease only shows CSS output. I've added option to views its LESS/SCSS equivalent.

To make adjustments one doesn't have to come back to site, adjustments can simply be done by changing variables.

@hojberg
Copy link
Owner

hojberg commented Nov 29, 2012

Sorry I have been unresponsive.
This is great stuff! It seems however to lack tests and switching between LESS to SCSS doesn't seem to work?

@miraff
Copy link

miraff commented Jan 14, 2013

I checked both the website and your source code but I cannot find any SCSS/LESS mentions. It's like the bfe96ef is gone. Can you please tell me how to get SCSS equivalent code?

@nitinhayaran
Copy link
Author

@hojberg Sorry for the delay.
Actually I don't have a very good understanding of testing that is why I haven't been able to add them.
And can you recheck the switching between LESS and SCSS should be working, there is not much difference in the code may be because of that you might have missed it.
The only difference is with the way variable are defined. i.e. $ vs @

@nitinhayaran
Copy link
Author

@mirabajer I couldn't understand what you are saying, I can see the commit and the code at https://github.com/nitinhayaran/cssarrowplease

@miraff
Copy link

miraff commented Jan 14, 2013

I don't understand it either. I cloned the repo, have master checked out, and here is the code from my local cssarrowplease / public / js / lib / views / arrow_css_view.js

http://pastebin.com/raw.php?i=ernUePyB

it does not correspond to the code here:

https://github.com/nitinhayaran/cssarrowplease/blob/master/public/js/lib/views/arrow_css_view.js

@miraff
Copy link

miraff commented Jan 14, 2013

I am stupid. I understand now. I was under the impression that hojberg already merged your commit to the mother repo since it has been here for months ... Sorry :)

@miraff
Copy link

miraff commented Jan 14, 2013

Got it working now. Would be good to rename the SCSS tab to SASS because you are using SASS syntax, not SCSS. Myself I use SCSS and I don't think I can use SASS syntax in my .scss files. BTW It's also possible that it's LESS syntax instead of SCSS which I don't know because I have never tried LESS, that would correspond to this second issue:

+1 on the LESS/SCSS tab switching which does not seem to work, both codes are the same.

@nitinhayaran
Copy link
Author

Aren't you getting following source code in SCSS tab:

$arrow_size : 30px;

$arrow_color: #88b7d5;

$arrow_border_width : 4px;

$arrow_border_color : #c2e1f5;

Check $ sign in variable declaration.

if this is the case then i think its scss, you can also try generating corresponding css at http://sass-lang.com/try.html

Its working find for me.

@hojberg hojberg closed this Dec 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants