Move redundant absolute positioning to shared styles and handle zero border width better#44
Merged
hojberg merged 2 commits intohojberg:masterfrom Nov 2, 2013
bra1n:master
Merged
Move redundant absolute positioning to shared styles and handle zero border width better#44hojberg merged 2 commits intohojberg:masterfrom bra1n:master
hojberg merged 2 commits intohojberg:masterfrom
bra1n:master
Conversation
added 2 commits
November 1, 2013 18:35
adjusted unittests to reflect changes
Owner
|
sweeeeeeeet! |
hojberg
added a commit
that referenced
this pull request
Nov 2, 2013
Move redundant absolute positioning to shared styles and handle zero border width better
Author
|
Would you mind updating cssarrowplease.com to the most recent version? |
Owner
|
@bra1n been having some npm issues. will deploy asap |
Owner
|
@bra1n deployed ;) |
Author
|
Awesome, thanks! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
it seems like the absolute positioning is the same for :after and :before in all cases, so there is no need to put it twice in the CSS. I moved it to the shared styles section (baseCSS) to save the user a redundant line. :)
Then there's the special case where you end up with 2 :after rules and no :before rule for a border width of zero, which I simplified into a single :after rule.
I also updated the unittests to reflect the changes.
What do you think?
Cheers,
bra1n