Fix issue preventing calculateCaretPosition from calculating correctly. #711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed an issue that's occurring in at least Chrome 74. Symptoms were the same as igorescobar#602.
was unneeded and failing tests
|
I will test this today @csmith93 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
calculateCaretPositionis being called in a timeoutel.data('mask-previus-value')was being updated prior tocalculateCaretPositionexecuting. The net outcome of this wasoldVal === newVal, so it'd never run anything inside the if statement on line 193.This caused the issues in #602 to show up again, which is how I discovered this.
Fix is to just cache the oldVal when the timeout is created, and pass it in to the function directly.