Add RecordingInputStream.asOutputStream()#108
Merged
Conversation
Member
Author
|
Thinking about it again I realised you can simplify the workaround by passing the data to read() and then have the wrapped InputStream do nothing and just pretend to have written to the buffer. Although I think InputStream ris = recorder.inputWrap(new InputStream() {
public int read(byte[] buffer, int off, int len) {
return len; // do nothing, buffer already has the expected data
}
public int read() { throw new AssertionError(); }
});
void onDataReceived(byte[] chunk) throws IOException {
ris.read(chunk, 0, chunk.length);
} |
3459ef4 to
d45d696
Compare
Using RecordingInputStream requires an awkward workaround when the API being recorded is not in the form of an InputStream, for example, if it's asynchronous. This adds a method to access the underlying RecordingOutputStream so you can write to it directly when that would be easier.
d45d696 to
cc85f05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using RecordingInputStream requires an awkward workaround when the API being recorded is not in the form of an InputStream, for example, if it's asynchronous. This adds a method to access the underlying RecordingOutputStream so you can write to it directly when that would be easier.
Before:
After: