BasicURLCanonicalizer: more efficient normalization of dots in host name#129
Merged
Merged
Conversation
ato
requested changes
Nov 12, 2025
| } | ||
| int start = 0, end = host.length(); | ||
| boolean changed = false; | ||
| while (host.charAt(start) == '.') { |
Member
There was a problem hiding this comment.
We should probably guard the loops to prevent StringIndexOutOfBoundsException on input like "." or "...". Obviously a proper URL isn't going to have an all dots host but someone could be using the canonicalizer on bogus extracted links.
Suggested change
| while (host.charAt(start) == '.') { | |
| while (start < end && host.charAt(start) == '.') { |
Collaborator
Author
There was a problem hiding this comment.
Thanks, good catch!
| start++; | ||
| changed = true; | ||
| } | ||
| while (host.charAt(end - 1) == '.') { |
Member
There was a problem hiding this comment.
Here too:
Suggested change
| while (host.charAt(end - 1) == '.') { | |
| while (end > start && host.charAt(end - 1) == '.') { |
Add unit test and prevent from StringIndexOutOfBoundsException.
Collaborator
Author
|
Thanks, @ato. The StringIndexOutOfBoundsException is fixed. Unit test added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces a chain of
String.replaceAll(...)by a dedicated method. More but faster code, avoiding unnecessary work.