Skip to content

fix: last header was lost if LF LF (intead of CRLF CRLF) #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ldko merged 1 commit into from
Feb 15, 2017
Merged

fix: last header was lost if LF LF (intead of CRLF CRLF) #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/java/org/archive/format/http/HttpHeaderParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,7 @@ public ParseState handleByte(byte b, HttpHeaderParser parser)
if(b == LF) {
// TODO: this is lax, is LFLF an OK terminator?
// that's all folks!
parser.headerFinished();
parser.parseFinished();
return parser.endState;
}
Expand Down
19 changes: 19 additions & 0 deletions src/test/java/org/archive/format/http/HttpResponseParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,23 @@ public void testParse() throws IOException {

}

public void testParseWithLf() throws IOException {

HttpResponseParser parser = new HttpResponseParser();
String message = "200 OK\nContent-Type: text/plain\n\nHi there";
try {
HttpResponse response =
parser.parse(new ByteArrayInputStream(message.getBytes(IAUtils.UTF8)));
assertNotNull(response);
HttpHeaders headers = response.getHeaders();
assertNotNull(headers);
assertEquals(1,headers.size());

} catch (HttpParseException e) {
e.printStackTrace();
fail();
}

}

}