Use CharsetDetector to guess encoding of HTML documents#68
Merged
ldko merged 4 commits intoFeb 15, 2017
Merged
Conversation
f9c8d42 to
607acaa
Compare
<META http-equiv=Content-Type content="text/html; charset=windows-1256">
ldko
reviewed
Jan 26, 2017
ldko
left a comment
Member
There was a problem hiding this comment.
I can confirm that running ResourceExtractor with this change worked for me to fix an encoding issue I had previously encountered in a generated WAT. Just one question...
| return value; | ||
| } | ||
| String result = value; | ||
| if (result.isEmpty()) |
Member
There was a problem hiding this comment.
Is this redundant to the prior if statement?
Collaborator
Author
There was a problem hiding this comment.
Yes, you're right. I've first fixed the charset detection in commoncrawl/ia-web-commons, and didn't pay enough attention when transferring the fix (CharsetDetector didn't have the "is empty" check on value).
I'll update the pull request. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commoncrawl#4