Improve HTML link extraction#72
Merged
Merged
Conversation
- add extractors for more elements which can take URLs as attribute values, add missing attributes - generalize extraction of "global" attributes (`background`) - add custom data attributes frequently used for linking (`data-href`, `data-uri`) - add unit test to cover link extraction
3ee87b7 to
11579c2
Compare
sebastian-nagel
added a commit
to commoncrawl/ia-web-commons
that referenced
this pull request
Feb 22, 2017
ldko
approved these changes
Mar 21, 2017
ldko
left a comment
Member
There was a problem hiding this comment.
This looks good to me and extracted/wrote more links to the WAT I generated with the changes. Thanks @sebastian-nagel !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
background)data-href,data-uri), cf. data-href not captured in WAT 'Links' metadata commoncrawl/ia-web-commons#7