WAT extractor: do not fail on missing WARC-Filename in warcinfo record#89
Merged
Merged
Conversation
fixes iipc#88 - do not throw IOException if there is no WARC-Filename in warcinfo record - write metadata record (corresponding to warcinfo) without WARC-Target-URI
ldko
reviewed
Jun 11, 2020
ldko
left a comment
Member
There was a problem hiding this comment.
Hi Sebastian, thanks for submitting this and all the details in the issue as well. The fix make sense to me and worked to fix the issue when I tried it with the sample WARC you provided in #88. If you have a moment, I noticed that the CHANGES.md does not reflect the last couple fixes you made, would you be willing to update the file to include this fix and #85 and #86 under a 1.1.10 heading? If not, I will take care of it. Thank you again!
Collaborator
Author
|
@ldko - updated the change log. Thanks! |
ldko
approved these changes
Jun 15, 2020
ldko
left a comment
Member
There was a problem hiding this comment.
Wonderful, thank you, @sebastian-nagel
sebastian-nagel
added a commit
to commoncrawl/ia-web-commons
that referenced
this pull request
Jun 15, 2020
sebastian-nagel
pushed a commit
to commoncrawl/ia-web-commons
that referenced
this pull request
Jun 15, 2020
sebastian-nagel
added a commit
to commoncrawl/ia-web-commons
that referenced
this pull request
Jun 15, 2020
sebastian-nagel
pushed a commit
to commoncrawl/ia-web-commons
that referenced
this pull request
Jun 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #88