issue-commons-app#3606: cancel in translate goes back to about screen

isnirp · isnirp · commit 882a6ec66247 · 2020-03-31T03:47:16.000+02:00
diff --git a/app/src/main/java/fr/free/nrw/commons/AboutActivity.java b/app/src/main/java/fr/free/nrw/commons/AboutActivity.java
@@ -152,7 +152,7 @@ public void launchTranslate(View view) {
                     String langCode = CommonsApplication.getInstance().getLanguageLookUpTable().getCodes().get(spinner.getSelectedItemPosition());
                     Utils.handleWebUrl(AboutActivity.this, Uri.parse(Urls.TRANSLATE_WIKI_URL + langCode));
                 });
-        builder.setNegativeButton(R.string.about_translate_cancel, (dialog, which) -> finish());
+        builder.setNegativeButton(R.string.about_translate_cancel, (dialog, which) -> dialog.cancel());
         builder.create().show();
 
     }

Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,7 @@ public void launchTranslate(View view) {`
`152`	`152`	`String langCode = CommonsApplication.getInstance().getLanguageLookUpTable().getCodes().get(spinner.getSelectedItemPosition());`
`153`	`153`	`Utils.handleWebUrl(AboutActivity.this, Uri.parse(Urls.TRANSLATE_WIKI_URL + langCode));`
`154`	`154`	`});`
`155`		`- builder.setNegativeButton(R.string.about_translate_cancel, (dialog, which) -> finish());`
	`155`	`+ builder.setNegativeButton(R.string.about_translate_cancel, (dialog, which) -> dialog.cancel());`
`156`	`156`	`builder.create().show();`
`157`	`157`
`158`	`158`	`}`