Skip to content

Bug fixes vis-a-vis current Firefox#1

Merged
hleinone merged 1 commit intojavanto:masterfrom
number61971:master
Jan 17, 2013
Merged

Bug fixes vis-a-vis current Firefox#1
hleinone merged 1 commit intojavanto:masterfrom
number61971:master

Conversation

@number61971
Copy link
Contributor

The ua.version comparison needs to be a float comparison, not string. (I.e., because current FF versions like "18.0" compare as < "2.0").

I also removed the explicit "font-size: 100px" setting because, in my own tests, that broke the element substitution in Firefox. The clickable area never matched the size of the replacement element unless I removed that font-size.

hleinone added a commit that referenced this pull request Jan 17, 2013
Bug fixes vis-a-vis current Firefox
@hleinone hleinone merged commit 29b3c31 into javanto:master Jan 17, 2013
@hleinone
Copy link
Member

That font-size was there because of the problems mentioned in here

That button looks just like the comp! But there is just one problem…the button is not clickable in certain areas in some browsers. So after talking with Jason about the problem, he suggested making the font size of the input really big. And it worked!

I'll have to test it and see if I can find browsers that are affected by the issue mentioned, and then decide if those browsers are relevant anymore.

Thank you for your fixes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants