Bug fixes vis-a-vis current Firefox#1
Merged
hleinone merged 1 commit intojavanto:masterfrom Jan 17, 2013
Merged
Conversation
…tting (breaks Firefox).
hleinone
added a commit
that referenced
this pull request
Jan 17, 2013
Bug fixes vis-a-vis current Firefox
Member
|
That
I'll have to test it and see if I can find browsers that are affected by the issue mentioned, and then decide if those browsers are relevant anymore. Thank you for your fixes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ua.version comparison needs to be a float comparison, not string. (I.e., because current FF versions like "18.0" compare as < "2.0").
I also removed the explicit "font-size: 100px" setting because, in my own tests, that broke the element substitution in Firefox. The clickable area never matched the size of the replacement element unless I removed that font-size.