Bug fixed & compression optimized using CSS color names#16
Merged
javierbyte merged 1 commit intojavierbyte:gh-pagesfrom Nov 11, 2015
Merged
Bug fixed & compression optimized using CSS color names#16javierbyte merged 1 commit intojavierbyte:gh-pagesfrom
javierbyte merged 1 commit intojavierbyte:gh-pagesfrom
Conversation
- The color optimization code was buggy for some colors such as fuchsia (#FF00FF) which was wrongly converted to red (#F00). RRGGBB colors were converted to 3-character-length notation RGG when possible and not RGB! - The use of CSS color names (and not hexadecimal notation) allow smaller notations which means a smaller output result.
javierbyte
added a commit
that referenced
this pull request
Nov 11, 2015
Bug fixed & compression optimized using CSS color names
Owner
|
Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RRGGBB colors were converted to 3-character-length notation RGG when possible and not RGB!