[JENKINS-63269] - Exclude JUnit and Hamcrest from the dependency list#2
Merged
Conversation
timja
approved these changes
Aug 1, 2020
Member
Author
|
Looks like I need to add CI there ... |
olamy
approved these changes
Aug 1, 2020
MarkEWaite
approved these changes
Aug 1, 2020
res0nance
approved these changes
Aug 2, 2020
Member
Author
|
I will verify it in the master branch. Thanks all! |
9 tasks
oleg-nenashev
added a commit
to jenkinsci/jenkins
that referenced
this pull request
Aug 2, 2020
10 tasks
timja
pushed a commit
to jenkinsci/jenkins
that referenced
this pull request
Aug 7, 2020
…ns.war bundle (#4890) Picks up jenkinsci/lib-commons-httpclient#2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on Jenkinsfile Runner, I have noticed that the Jenkins Core includes JUnit JAR and Hamcrest JARs as transitive dependencies. Looks like it was my mistake in 2017 when I was working on a custom patch for
commons-httpclientwith vulnerability fix backports. It leads to 350KB of extra libraries, and, which is worse, potentially messes up the classpaths for testing environments and plugins.https://issues.jenkins-ci.org/browse/JENKINS-63269
Dependency tree:
Screenshot of a jenkins.war: