Skip to content

Added a live selector#8

Open
Sebmaster wants to merge 6 commits intojoewalnes:masterfrom
Sebmaster:master
Open

Added a live selector#8
Sebmaster wants to merge 6 commits intojoewalnes:masterfrom
Sebmaster:master

Conversation

@Sebmaster
Copy link

This setting allows one to bind to a parent element while still only showing the contextmenu on specific child elements.

This simplifies the case where child elements get added dynamically.

Since on() is used, jQuery 1.7 is required. I updated the example(s) to reflect that.

Sebmaster added 3 commits July 6, 2012 11:34
This setting allows one to bind to a parent element while still only showing the contextmenu on specific child elements.

This simplifies the case where child elements get added dynamically.
@joewalnes
Copy link
Owner

Thanks for the contribution.

Code looks good.

Please can you add some documentation to the README explaining what it does and how to use it. Also a demo in the /demo/ dir would be good.

Thanks
-Joe

@Sebmaster
Copy link
Author

I don't know if Github sends notifications when a commit gets added so I'll just put this here as a reminder :-p

I thought about patching more events/hooks into contextmenu (mainly onFocus/onShow) to allow one to modify the DOM for the created menu (disabling entries come to mind). Will you pull that too?

@Sebmaster
Copy link
Author

There you go :)

@joewalnes
Copy link
Owner

I thought about patching more events/hooks into contextmenu (mainly
onFocus/onShow) to allow one to modify the DOM for the created menu
(disabling entries come to mind). Will you pull that too?

Yes, I would pull those changes too - though best to wrap them up into a
separate branch/pull request.

Thanks for all this!

@Sebmaster
Copy link
Author

Okay I have a few changes for the action event/dynamic generation ready as soon as you pull this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments