Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: johnny/jquery-sortable
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4d31eea
Choose a base ref
...
head repository: sdumetz/jquery-sortable
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: d2c27f3
Choose a head ref
  • 6 commits
  • 3 files changed
  • 1 contributor

Commits on Jun 2, 2014

  1. fixed getPointer & drag functions for touch screen 

    getPointer and drag were not setting position when using a touch device.

This quick fix may not work properly when using multitouch but I didn't saw any problem on chrome emulation and on my phone.

There is multiple ways to get the touch event's position and I might not use the best one. Maybe someone with experience in the matter could improve this solution?
    Sebastien Dumetz committed Jun 2, 2014
    Configuration menu
    Copy the full SHA
    c50e137 View commit details
    Browse the repository at this point in the history

  2. isValidDrag should ignore "tap" events 

    detect ̀ ``touchmove``` instead of `̀``touchstart``` event. This way we ignore simple "taps" on screen, meant to use links, etc...
    Sebastien Dumetz committed Jun 2, 2014
    Configuration menu
    Copy the full SHA
    8e5fd30 View commit details
    Browse the repository at this point in the history

  3. added the middleman command to start dev version

    Sebastien Dumetz committed Jun 2, 2014
    Configuration menu
    Copy the full SHA
    5a859df View commit details
    Browse the repository at this point in the history

  4. gitignored rvm files

    Sebastien Dumetz committed Jun 2, 2014
    Configuration menu
    Copy the full SHA
    c05f7af View commit details
    Browse the repository at this point in the history

  5. Merge branch 'patch-1'

    Sebastien Dumetz committed Jun 2, 2014
    Configuration menu
    Copy the full SHA
    aa79f87 View commit details
    Browse the repository at this point in the history

  6. registered touchmove as event for drag detection

    Sebastien Dumetz committed Jun 2, 2014
    Configuration menu
    Copy the full SHA
    d2c27f3 View commit details
    Browse the repository at this point in the history
Loading