fixed getPointer & drag functions for touch screen#104
Closed
sdumetz wants to merge 1 commit intojohnny:masterfrom
Closed
fixed getPointer & drag functions for touch screen#104sdumetz wants to merge 1 commit intojohnny:masterfrom
sdumetz wants to merge 1 commit intojohnny:masterfrom
Conversation
getPointer and drag were not setting position when using a touch device. This quick fix may not work properly when using multitouch but I didn't saw any problem on chrome emulation and on my phone. There is multiple ways to get the touch event's position and I might not use the best one. Maybe someone with experience in the matter could improve this solution?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getPointer and drag were not setting position when using a touch device.
This quick fix may not work properly when using multitouch but I didn't saw any problem on chrome emulation and on my phone.
There is multiple ways to get the touch event's position and I might not use the best one. Maybe someone with experience in the matter could improve this solution?