Merged
Conversation
|
Hello, the current plugin code from "master" does not work properly because of this pull request, since the new options are not copied in container group options and therefore are not set. As a result, the about-to-be-dragged element always sticks to the 0,0 point of the screen. @jgerigmeyer, could you please have a look and review your patch is complete and merged properly in master branch? Thank you for the great work, guys! |
Contributor
Author
|
@petr-inmite I'm not currently using this plugin, but it was working for me when I was. Could you submit a PR of your own, or include an example (jsfiddle or similar) demonstrating the bug? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of forcing
.dragged,.dragging, and.placeholder, this PR allows users to set custom classes using newbodyClass,draggedClass, andplaceholderClassoptions.Fixes #118.