Skip to content

mobile fixes for touchstart and pageX/Y #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
blented wants to merge 1 commit into from
Closed

mobile fixes for touchstart and pageX/Y #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions source/js/jquery-sortable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,9 @@
// If true, search for nested containers within an item
nested: true,
// If true, the items are assumed to be arranged vertically
vertical: true
vertical: true,
// Wether or not to prevent default on touchstart, allowing for drag on mobile devices
touchDrag: true,
}, // end container defaults
groupDefaults = {
// This is executed after the placeholder has been moved.
Expand Down Expand Up @@ -250,6 +252,9 @@
!this.options.onMousedown(this.item, groupDefaults.onMousedown, e)){
return
}
// lets touchstart drags work on mobile
if (event.type == 'touchstart' && this.options.touchDrag)
e.preventDefault()

this.setPointer(e)
this.toggleListeners('on')
Expand All @@ -274,8 +279,8 @@
groupDefaults.onDrag,
e)

var x = e.pageX || e.originalEvent.pageX,
y = e.pageY || e.originalEvent.pageY,
var x = e.pageX || e.originalEvent.touches[0].pageX,
y = e.pageY || e.originalEvent.touches[0].pageY,
box = this.sameResultBox,
t = this.options.tolerance

Expand Down Expand Up @@ -398,8 +403,8 @@
},
getPointer: function(e) {
return {
left: e.pageX || e.originalEvent.pageX,
top: e.pageY || e.originalEvent.pageY
left: e.pageX || e.originalEvent.touches[0].pageX,
top: e.pageY || e.originalEvent.touches[0].pageY
}
},
setupDelayTimer: function () {
Expand Down