Skip to content

Fixes #53: input elements can still gain focus on click when inside sortable elements #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnny merged 1 commit into from
Dec 4, 2013
Merged

Fixes #53: input elements can still gain focus on click when inside sortable elements #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions source/js/jquery-sortable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,12 @@
$("body").removeClass("dragging")
},
// Called on mousedown. If falsy value is returned, the dragging will not start.
onMousedown: function($item, _super, event) {
event.preventDefault()
return true
// If clicked on input element, ignore
onMousedown: function ($item, _super, event) {
if (event.target.nodeName != 'INPUT') {
event.preventDefault()
return true
}
},
// Template for the placeholder. Can be any valid jQuery input
// e.g. a string, a DOM element.
Expand Down