Fix issue where name was doubled up when using EditorFor #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnyreilly
added a commit
that referenced
this pull request
Sep 2, 2013
Fix issue where name was doubled up when using EditorFor.
|
@davidcarroll - that's brilliant; a much nicer solution! I'm planning to push out a new version to Nuget within the next week and I'll include this with it. I'm just working on a globalization tweak that I want to ship at the same time. Thanks so much for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi John,
I figured out a simpler way to fix this issue instead of futzing with the name. I just used TextBoxFor helper instead of the TextBox helper. This way, there is no need to pass in a name and MVC will just figure it out. Actually the only difference in the useNativeUnobtrusiveAttributes switch is we pass MVC your extended attributes instead of the original attributes.
All tests pass.