Conversation
imageAlpha reduced PNGs to 64 & 32 colors imageOptim reduced all file sizes
removed `if (axisClip)` check, since no clipping ends before, & fall-through naturally is only those that need clipping
This reverts commit c8aabe0.
So, no longer need `if (axisClip) since 'No clipping' now `return`s
|
Thanks Tom, these changes all make sense. Do you want me to merge these soon or do you want to keep working on stuff? I know I said I prefer a single commit per issue but I don't want to merge any revert commits - so I'd be happy for you to squash all of this in to one commit if you like, call it something like 'Optimisations' and just summarise each of the things you did in the message. |
|
Or rather, squash the last 4 in to one. May as well leave the image one separate. Or whatever :D |
Sounds like best bet. Might be day or 3. |
reorganized `var` declarations, `if/else` and assignments to related groupings removed redundant `dataAxis` (`a`) var; only need `dataClippingAxis`
don't need to look up same element 4 times ;)
Should be slightly faster, at least to read with human eyes ;)
|
Thanks for your efforts Tom. If there's no significant performance gain I'm not likely to merge tomByrer@d94272d. There's a real benefit to me in keeping it all on an object in that I can use the console to debug |
changes to date