-
Notifications
You must be signed in to change notification settings - Fork 67
Remove the overwriting of the default <a> functionality #84
Comments
You're right, according to the goals of the project we probably shouldn't have used the mixin and overwritten the default functions of |
Excellent! I'd really love to see something like this succeed and push standards with improved patterns and practise. It'll require strict discipline on the part of everyone involved in order to truly do so though. It's easy (done it myself countless times) to get caught up replacing built in functionality with something shiny. |
Might help to rename this issue or replace it with a new one to track down specific issues like the one outlined above. |
Will do, @jzaefferer, was planning on doing it after today's meeting, so we can specify exactly what we need to replace. Some of this deals with stuff in the #41 we're working on creating, and we're still figuring out what should (and should not) be in the code. |
I thought about adding to the existing discussion on closed issue #38 but I didn't want it to be missed.
Quoting a reply in the discussion.
This doesn't seem accurate.
Looking at the code here it seems that the project is already drifting away from basic rules to opinionated design that will have a marked effect on both the ability of developers to overwrite basic styles and the rendering performance within browsers.
https://github.com/jquery/css-chassis/blob/64a51ac31474f7b2c413f8d1767ca776f76228fd/scss/atoms/typography/_typography.scss
Take the code and mixin that is referenced here
There's now a global selector with a specificity of 0,0,2 that will affect every page the code is added to. It's overwriting the default styles applied to an
a
tag with behaviour reduces visibility of the link, requires more processing power, and includes hacks for webkit browsers.https://github.com/jquery/css-chassis/blob/64a51ac31474f7b2c413f8d1767ca776f76228fd/scss/atoms/typography/_mixins.scss
Is this really the intended direction of the project? It seems not.
The text was updated successfully, but these errors were encountered: