Skip to content
This repository was archived by the owner on Dec 11, 2021. It is now read-only.

Build: Must run variables task as part of the build #104

Closed
wants to merge 3 commits into from

Conversation

arschmitz
Copy link
Contributor

This fixes the current CI failure

@jzaefferer
Copy link
Contributor

Travis says NO

@sfrisk
Copy link
Contributor

sfrisk commented Jul 24, 2015

Looks like the /dist folder isn't getting created in time.

@rohmulan
Copy link
Contributor

i pulled it in and ran Grunt, works fine 👍
Update: No it doesn't, but last night i had just replicated @arschmitz's changes to my local copy to get grunt build to work and it had worked just fine.

@rohmulan
Copy link
Contributor

The folder needs to exist for jsass-vars to create the file. I just made the folder and ran things and everything went smoothly.
should be more of a fix in jsass-vars to create any folders needed to create the file ?

@arschmitz
Copy link
Contributor Author

@geekman-rohit your correct

@sfrisk sfrisk mentioned this pull request Jul 27, 2015
@sfrisk
Copy link
Contributor

sfrisk commented Aug 3, 2015

If everyone is okay with this, I'm bringing it in.

@rohmulan
Copy link
Contributor

rohmulan commented Aug 3, 2015

LGTM 👍

@arschmitz arschmitz closed this in 509a5dc Aug 4, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants