This repository was archived by the owner on Dec 11, 2021. It is now read-only.
Linting:Add scss variable files to linting #105
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,6 @@ | |||
| // This is just boiuler plate dont worry about it | |||
| // This just supports loading in any enviroment | |||
| (function ( root, factory ) { | |||
| ( function( root, factory ) { | |||
| if ( typeof define === "function" && define.amd ) { | |||
| define( [], factory ); | |||
There was a problem hiding this comment.
Looks like this file has wrong indentation, skipped my notice, I'll fix that
|
@sfrisk , updated the PR |
| options: { | ||
| fix: true | ||
| } |
There was a problem hiding this comment.
I ran it once with fix true no issues. We could get rid of the option now or do we want to keep it ? @arschmitz ?
There was a problem hiding this comment.
Per discussion with @arschmitz, fix should not be in the repo at all.
There was a problem hiding this comment.
yep that shouldn't be here, I actually forgot to remove it. Thanks for reminding.
8397f37 to
ea9006e
Compare
|
@sfrisk updated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds jsass-vars scss variable files from scss/varibales/ folders to js linting.