Initial files and initial demo styles added #144
Conversation
|
|
||
| @import | ||
| "dist/chassis", | ||
| "functions", |
There was a problem hiding this comment.
empty file, remove this and the file for now, add later when there is something to do in functions file
|
@nashvail all your styles are direct css. Use some variables to make it easier to modify ur styles. |
| input[type=email], | ||
| input[type=search], | ||
| input[type=password] { | ||
| font-family: "Source Sans Pro"; |
There was a problem hiding this comment.
This should pull from a variable font, and we currently do not use "Source Sans Pro" anywhere
Removed empty files,variables for colors, autoprefixr to handle vendor prefixes
|
Sorry for so many inconsistencies, just getting familiar with the code base. Hope the latest commit is compatible |
|
@nashvail Looks like you're currently a few commits behind master, and you have some conflicts with master that need resolving. If you merge in master, you can look at the code for how we did buttons, to get an idea for how we expect variables to be used. As it is, I'm not sure using
|
| input[type=password] { | ||
| border-radius: 2px; | ||
| border: 1px solid map-get($text, light); | ||
| box-shadow: inset 0 1px 3px rgba(0,0,0,.24); |
There was a problem hiding this comment.
Working exactly on that, wasn't aware of the way variables are used. Looking at the button example gave the idea.
|
@nashvail please go through existing code to see how we declare varibles and where and when we do it. |
Removed _styles suffix
gw-jsassvars is enabled in this commit
| }( this, function( chassis ) { | ||
|
|
||
| chassis.input = { | ||
| "ui-input-shadows": { |
| <input type="text" placeholder="Name"> | ||
| <input type="email" placeholder="Email"> | ||
| <input type="password" placeholder="Password"> | ||
| <input type="text" placeholder="Locaiton" value="Earth" readonly disabled> |
There was a problem hiding this comment.
Typo for the word "Location"
|
Could you please address the additional form elements in #6 |
| <div class="demo_container"> | ||
| <h1>CSS Chassis</h1> | ||
| <div class="demo_container__inputs"> | ||
| <input type="text" placeholder="Name"> |
There was a problem hiding this comment.
Demos with inputs should show labels associated with them to help enforce best practices, since placeholders should not be used as a label
For issue 10 : #10