New Component: Modals

[nashvail]

No description provided.

[jquerybot]

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.

---

If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

[cvrebert]

I suggest including an example where the modal's content is taller than the viewport (and thus, scrolling is required).

[cvrebert]

Hardcoded tag selector :-/

[nashvail]

The default one as styled in typography.scss has wide top and bottom margins so I had to override that.

[cvrebert]

What about a .modal-title class then?

[sfrisk]

In general we want to avoid cascading as well. Have modal-title so they can use whatever element they need semantically, and remove modal-header cascading from inside modal.

Sent from my iPhone

On May 27, 2016, at 4:43 PM, Chris Rebert notifications@github.com wrote:

In scss/atoms/modals/_modals.scss:

+* ==========================================================================
+* Modals
+* ==========================================================================
+*/
+
+@import

• "dist/chassis",
• "functions",
• "mixins";

+.modal {

• @include modal();

• .modal-header {

•   @include modal-header();
  

•   h4 {
  

  What about a .modal-title class then?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[sfrisk]

button stacking is a little awkward in mobile.

[sfrisk]

for something like this, maybe a common demo.css file would be better, than separate stylesheets for everything?