Buttons: Removed underline from link buttons on hover #166
Conversation
|
Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA). 📝 Please visit http://contribute.jquery.org/CLA/ to sign. After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know. If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check. |
| // To remove the underline that appears when hovering link styled buttons | ||
| a.btn:hover, | ||
| a.btn.hover { | ||
| text-decoration: none; |
There was a problem hiding this comment.
I wouldn't add this here, but as part of the hover related mixin.
3970736 to
587529f
Compare
| @@ -36,6 +36,10 @@ | |||
| @include btn-hover($btn-colors); | |||
| } | |||
|
|
|||
| &:hover { | |||
| text-decoration: none; | |||
| } | |||
There was a problem hiding this comment.
why not just add it to :hover/.hover above ??
There was a problem hiding this comment.
.hover already inherits the text-decoration: none from the btn mixin up above (line 8). This is dealing with browser defaults overwriting the pseudo class functionality.
For issue #165