CONTRIBUTING:Mention the IRC logs in contributing.md #171
Conversation
|
Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA). 📝 Please visit http://contribute.jquery.org/CLA/ to sign. After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know. If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check. |
|
@sumedh123 you'll have to sign the CLA with your name and email as used on Github. http://contribute.jquery.org/CLA/ |
|
I just signed @geekman-rohit |
There was a problem hiding this comment.
@arschmitz , @sfrisk seems like an addition we could have, though I don't think its entirely necessary ? Opinion?
|
We've had an open issue for this #160 |
| @@ -5,3 +5,6 @@ You may also want to take a look at our [commit & pull request guide](http://con | |||
| You can find us on [IRC](http://irc.jquery.org), specifically in #css-chassis should you have any questions. If you've never contributed to open source before, we've put together [a short guide with tips, tricks, and ideas on getting started](http://contribute.jquery.org/open-source/). | |||
|
|
|||
| Our weekly meetings on Tuesday at 2pm ET on [IRC](http://irc.jquery.org) in #jquery-meeting. These meetings are public and all are welcome to attend and participate. If you can't make the meeting, you can find the internal notes for each meeting on [the jQuery Meeting site](https://meetings.jquery.org/category/chassis/). | |||
|
|
|||
| In case you have missed the meetings or want to view the discussions, you can view the irc logs here. | |||
| https://irc.jquery.org/%23jquery-meeting/ | |||
There was a problem hiding this comment.
Instead of just posting the url in plaintext, have the url be a href link to "view the irc logs" and remove the word "here", similar to how the link is for "the jQuery Meeting Site"
| @@ -5,3 +5,6 @@ You may also want to take a look at our [commit & pull request guide](http://con | |||
| You can find us on [IRC](http://irc.jquery.org), specifically in #css-chassis should you have any questions. If you've never contributed to open source before, we've put together [a short guide with tips, tricks, and ideas on getting started](http://contribute.jquery.org/open-source/). | |||
|
|
|||
| Our weekly meetings on Tuesday at 2pm ET on [IRC](http://irc.jquery.org) in #jquery-meeting. These meetings are public and all are welcome to attend and participate. If you can't make the meeting, you can find the internal notes for each meeting on [the jQuery Meeting site](https://meetings.jquery.org/category/chassis/). | |||
|
|
|||
| In case you have missed the meetings or want to view the discussions, you can <a href = "https://irc.jquery.org/%23jquery-meeting/">view the irc logs here.</a> | |||
There was a problem hiding this comment.
Please use markdown syntax for the link, not html
|
|
8900c1a to
5f085bd
Compare
…hub.com/sumedh123/css-chassis into 160_mention_irc_logs_in_CONTRIBUTING.md
|
I have signed the CLA and its status page shows "All of the commits have proper CLA signatures. Thanks for contributing!", still there is CLA : error label? why is it so? |
IRC logs link mentioned in CONTRIBUTING.md.