This repository was archived by the owner on Dec 11, 2021. It is now read-only.
Performance: Add topcoat framework to test suite #45
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| module.exports = { | ||
| css: [ | ||
| "//cdnjs.cloudflare.com/ajax/libs/topcoat/0.8.0/css/topcoat-mobile-dark.css", | ||
| "//cdnjs.cloudflare.com/ajax/libs/topcoat-icons/0.2.0/font/icomatic.css" | ||
| ], | ||
| button: { | ||
| generator: function( options ) { | ||
| var button = "<button class='"; | ||
| var icon = ""; | ||
| var buttonText = " Button"; | ||
|
There was a problem hiding this comment. Make this |
||
| var buttonClass = 'topcoat' + options.type + '-button'+ options.size; | ||
|
There was a problem hiding this comment. |
||
|
|
||
| //Icon Buttons donot support the cta button type | ||
|
There was a problem hiding this comment. Spacing |
||
| if( options.type !== '-icon' || options.state !== '--cta' ) { | ||
|
|
||
| buttonClass = buttonClass + options.state; | ||
|
|
||
| } | ||
| button = button + buttonClass + "'>"; | ||
|
There was a problem hiding this comment. Use |
||
|
|
||
| //Add icon only if it is a icon-button or there is an icon set | ||
|
|
||
| if( options.icon !== "" || options.type === "-icon" ) { | ||
|
There was a problem hiding this comment. I would like to see all the icon logic grouped together like in my previous example. There was a problem hiding this comment. also just do |
||
| icon = "<span class='"; | ||
|
There was a problem hiding this comment. This should be combined with line 29 |
||
| iconClass="topcoat-icon"; | ||
|
There was a problem hiding this comment. You never define this above so your creating a global. |
||
|
|
||
| //If it is an icon button, add size to class and reset buttonText | ||
|
There was a problem hiding this comment. All these comments need spaces after the slashes. // If it is an icon button, add size to class and reset buttonText |
||
| if( options.type === "-icon" ) { | ||
|
|
||
| buttonText = ""; | ||
|
There was a problem hiding this comment. This line can be removed if you change the declaration above. |
||
| iconClass = iconClass+options.size; | ||
|
There was a problem hiding this comment. You never define this above so your creating a global. |
||
| } | ||
| icon = icon + iconClass +" icomatic'>" + options.icon + "</span>"; | ||
|
|
||
| } | ||
| return button + icon + buttonText + "</button>"; | ||
| }, | ||
| variations: { | ||
| type: [ | ||
| "", | ||
| "-icon", | ||
|
|
||
| ], | ||
| size: [ | ||
| "", | ||
| "--large", | ||
|
|
||
| ], | ||
| state: [ | ||
| "", | ||
| "--cta", | ||
| "--quiet", | ||
|
|
||
|
|
||
| ], | ||
| icon: [ | ||
| "", | ||
| "location", | ||
| "home", | ||
| "alert" | ||
| ] | ||
|
|
||
| } | ||
| }, | ||
|
|
||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| module.exports = { | ||
| css: [ | ||
| "//cdnjs.cloudflare.com/ajax/libs/topcoat/0.8.0/css/topcoat-desktop-dark.css", | ||
| "//cdnjs.cloudflare.com/ajax/libs/topcoat-icons/0.2.0/font/icomatic.css" | ||
| ], | ||
| button: { | ||
| generator: function( options ) { | ||
| var button = "<button class='"; | ||
| var icon = ""; | ||
| var buttonText = " Button"; | ||
| var buttonClass = 'topcoat' + options.type + '-button'+ options.size; | ||
|
|
||
| //Icon Buttons donot support the cta button type | ||
| if( options.type !== '-icon' || options.state !== '--cta' ) { | ||
| buttonClass = buttonClass + options.state; | ||
| } | ||
| button = button + buttonClass + "'>"; | ||
|
|
||
| //Add icon only if it is a icon-button or there is an icon set | ||
| if( options.icon !== "" || options.type === "-icon" ) { | ||
| icon = "<span class='"; | ||
| iconClass="topcoat-icon"; | ||
|
|
||
| //If it is an icon button, add size to class and reset buttonText | ||
| if( options.type === "-icon" ) { | ||
| buttonText = ""; | ||
| iconClass = iconClass+options.size; | ||
| } | ||
| icon = icon + iconClass +" icomatic'>" + options.icon + "</span>"; | ||
| } | ||
| return button + icon + buttonText + "</button>"; | ||
| }, | ||
| variations: { | ||
| type: [ | ||
| "", | ||
| "-icon", | ||
| ], | ||
| size: [ | ||
| "", | ||
| "--large", | ||
| ], | ||
| state: [ | ||
| "", | ||
| "--cta", | ||
| "--quiet", | ||
|
|
||
| ], | ||
| icon: [ | ||
| "", | ||
| "location", | ||
| "home", | ||
| "alert" | ||
| ] | ||
|
|
||
| } | ||
| }, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing indentation?