Build: Add normalize.css and include in default build #66
Conversation
This includes normalize.css in the external folder and includes it as part of the default build. Fixes jquery-archivegh-7 Closes jquery-archivegh-66
| @import | ||
| "views/main"; | ||
| "external/normalize.css/normalize.scss", | ||
| "lint.scss"; |
There was a problem hiding this comment.
Is there a reason why you took out links to utilities/colors/icons/typography/etc?
There was a problem hiding this comment.
oh wait, I see it now in lint.scss.
Not certain how I feel moving a lot of this outside of styles.scss and into lint.scss.
There was a problem hiding this comment.
Except the comment explaining it i forgot to save in lint.css ill add it now
There was a problem hiding this comment.
Also as calling it lint.scss will mean we're going to have a compiled lint.css file as well as a style.css. If you're going to pull all of that out of styles.scss, then probably call it _lint.scss so it is at least following SASS conventions about using a _ in a file name as indicating it's a partial)
There was a problem hiding this comment.
It needs to be compiled in 2 locations that the whole point we need to make a compiled file to lint.
There was a problem hiding this comment.
Ah okay. Just feels a little dirty I guess. :-/
There was a problem hiding this comment.
If you look at the comments in the lint.scss and the comments and tasks for this in the grunt file it should be clear to contributors the purpose of this i think. Im open to a better way to do it but i don't think there is one unless we just don't lint our distributable which seems like a bad idea.
This includes normalize.css in the external folder and includes it as part of the default build. Fixes jquery-archivegh-7 Closes jquery-archivegh-66
This includes normalize.css in the external folder and includes it as part of the default build. Fixes jquery-archivegh-7 Closes jquery-archivegh-66
This includes normalize.css in the external folder and includes it as part of the default build. Fixes jquery-archivegh-7 Closes jquery-archivegh-66
| @@ -41,6 +41,7 @@ | |||
| "test": "grunt" | |||
| }, | |||
| "dependencies": {}, | |||
|
|
|||
There was a problem hiding this comment.
Should this line be here? We don't do this for other objects as well right?
There was a problem hiding this comment.
Actually normalize.css should be here it is a dependency not a dev dependency but the blank line was an error.
This includes normalize.css in the external folder and includes it as part of the default build. Fixes jquery-archivegh-7 Closes jquery-archivegh-66
This includes normalize.css in the external folder and includes it as
part of the default build.
Fixes gh-7
Closes gh-66