Table styling#69
Conversation
There was a problem hiding this comment.
Setting the padding for ths twice (see line 23) seems weird.
There was a problem hiding this comment.
It appears that way, but they aren't. The em values are different since the font size of th is smaller.
There was a problem hiding this comment.
In that case is there really a point in combining the td and th rules here since they only actually share 2 properties top border and white space. Maybe just add those 2 properties here to the th rule and have above just be td It will make it more clear whats going on to avoid confusion.
There was a problem hiding this comment.
Will split these up. Probably not worth the combo.
|
@MichaelArestad awesome, I especially love what you did with responsive tables. |
|
any specific reasons why headings are less dark and smaller than rest of table by default? I thought it should be other way round? |
Yep. The other way around is just a browser default leftover. They are just the labels for the content. The content should be the easiest thing to read. If they are all bold, the |
|
Thought i added this but i don't see it live preview link http://view.css-chassis.com/table/demos/tables.html |
|
👍 looks great |
509891d to
14b36cf
Compare
14b36cf to
0660ad2
Compare
|
Note: error due to BEM class name. |
|
Yup looks like we need to modify our settings |
|
@arschmitz Yep. We should do another PR for fine-tuning the |
There was a problem hiding this comment.
Note for later: Remove nowrap on td.
|
Fixed a few things and separated overflow styles (fancy gradient) into its own component, |
There was a problem hiding this comment.
"slime" [sic]
Also, the "reimplementing underlines" technique in general seems (a) overcomplicated/overkill (b) not easy to override
|
Replaced by #69 |
|
@jzaefferer replaced by #130... you mean? |
|
Yes, copy pasta error. |
Super basic v1 of table styling. Looks like this currently and include some fancy overflow styles.
Thoughts?