This repository was archived by the owner on Dec 11, 2021. It is now read-only.
Colors: Adding Chassis palette and default colors #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting out with the rules we use from jquery-ui for consistency sake. If we need to tweak these later, we can.
|
Upon further consideration, tweaking the palette names to be a bit more generic, to allow for an easy demo file of the palette. |
| $color-button: $blue; | ||
| $color-button-text: $gray-light; | ||
|
|
||
| // $color-success: $blue; |
There was a problem hiding this comment.
You might suggest naming these something like $color-alert-yellow.
|
redoing this in a different way. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a color palette file where we can define palette variables. The theme roller could potentially edit this file with a custom palette and then adjust the variable values in _colors.scss accordingly.
Edited the _colors.scss file to include some base color variables that could goes along with the typography PR, with appropriate palette variables assigned it it. Commented out success/error/warning variables are there mostly because I think this ties in with validation styling, and I wasn't quite sure what colors in the current palette would work with these variables, or if we should add additional colors for these cases. I am open to suggestions on this point. That or I could just remove those variable declarations for now and we could address them when we get to #9.