Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Add support for data-role="dialog" #3276

@toddparker

Description

@toddparker

We're seeing some people try and use data-role="dialog" which isn't a valid role yet in the framework. You make a dialog by linking with data-rel="dialog" on a link but in non-ajax situations, people must be trying this instead. The dialog role results in a blank page because it's not valid today.

For 1.1 we can try and re-work the navigations script to support data-role="dialog" so dialog appearance can work in non-Ajax nav situations. This is mostly the same as the normal page enhancements, but the dialog classes to give it an inset appearance need to be support the normal dialog config attributes for the overlay swatch and such.

Test page:
http://jsbin.com/uyinaf/2

This shows up blank if you have a role of dialog instead of page.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions