Slider/Flip toggle switch don't slide with 1.7 update

[johnbender]

Thanks to the awesome tests added by @redaemn I spotted that the slider controls are no longer responding to mouse events properly.

[johnbender]

The issue here is the $.event.props changed from a comprehensive list into a subset of the original and pushed pageX and pageY down into $.event.mouseHooks.props.

The commit in core that made the change:

jquery/jquery@b4120a7

@dmethvin has been consulted to see if this is in the release notes or if there are recommendations on avoiding further issues.

[redaemn]

@johnbender

Happy that the tests were useful!! :D

[dmethvin]

I have some completed docs on this but haven't yet found the right venue to publish them. The ticket itself was in the release notes but that's easy to miss.

So anyway, in createVirtualEvent it looks like that code was copied from UI and I am still not clear on the comment there about "fixing" the event multiple times. The jQuery.event.fix method is intended to normalize a browser event into a jQuery.Event object. Once you have a jQuery.Event object there shouldn't be a need to fix it again, since the event has already been normalized to the best of jQuery's ability. You can just copy over all of its properties. I recall talking to @scottgonzalez about using jQuery.extend for this but can't recall if there were specific issues that prevented it.

Most likely this is pointing towards a need for something like the ability for jQuery.Event to accept an existing Event object and copy its properties, because we definitely shouldn't have UI and Mobile doing a copy-pasta on parts of jQuery.event.fix.