Write unit tests for single module support #5987

jzaefferer · 2013-05-09T22:17:51Z

As discussed on the jquery-devs-team mailing list. These were my notes about issues when trying to use jQuery Mobile without the init module, in a very simple example:

Apart from an issue with nested listviews its mostly adding classes to various elements: ui-mobile to <html>, ui-mobile-viewport to <body>, ui-page and ui-page-active to a <div> that contains the actual content. And a few swatch classes to make things look okay.

Doesn't seem so bad now, but since this approach isn't documented anywhere (right?), I had to cobble that together from the generated markup. And the example really wasn't doing much. just a header, footer, a bit of navigation and a listview.

The text was updated successfully, but these errors were encountered:

arschmitz · 2013-05-10T13:40:50Z

@jzaefferer for listview specifically this can now be used independantly with out pages on the js side on master, @uGoMobi is working on fixing up the css to match on branch next so the classes you mention will not be needed.

toolbars & navbars also work independent of pages in branch pageSections. Hoping to be able to do the same with the rest of the widgets for 1.4

jaspermdegroot · 2013-05-29T21:22:27Z

Ticket for listviews without page: #5429 (this is fixed in branch "next").

jzaefferer · 2013-07-04T10:52:22Z

This is labelled "Fixed in next", since that branch landed in master, does that means this ticket can be closed?

jaspermdegroot · 2013-07-04T11:12:37Z

@jzaefferer

I added that label when the work on listview was done in branch "next", but didn't close the issue after the merge because I realized the ticket is not only about listview. This is not done yet for all widgets or the changes are still in branches, so I'll remove that label.

jaspermdegroot · 2013-08-13T08:42:38Z

@arschmitz @gabrielschulhof

Are there still widgets that don't work outside page / without init module?

gabrielschulhof · 2013-08-15T17:29:40Z

Yes. Collapsibleset does not work without the page, because the page contains the code that causes initSelector to be added to the collapsible constructor ($.mobile.collapsible.initSelector). Collapsibleset uses this initSelector to select the children that should be turned into collapsibles.

gabrielschulhof · 2013-08-15T17:57:02Z

Controlgroup will also not work because it too relies on initSelector.

Re gh-5987 Re gh-7294

Closes gh-7295 Fixes gh-7294 Re gh-5987

(cherry picked from commit dc3fa7d) Closes gh-7295 Fixes gh-7294 Re gh-5987

Re gh-5987

Both modules have a hard dependency on the "vmouse" module that should be expressed in AMD. Re jquery-archivegh-5987 Closes jquery-archivegh-7274

Both modules have a hard dependency on the "vmouse" module that should be expressed in AMD. Re gh-5987 Closes gh-7383 Closes gh-7274

Both modules have a hard dependency on the "vmouse" module that should be expressed in AMD. Re gh-5987 Closes gh-7383 Closes gh-7274 (cherry picked from commit 44e2d98)

Re jquery-archivegh-5987

Re gh-5987

Both modules have a hard dependency on the "vmouse" module that should be expressed in AMD. Re jquery-archivegh-5987 Closes jquery-archivegh-7383 Closes jquery-archivegh-7274

Re jquery-archivegh-5987

Re gh-5987

apsdehal · 2016-05-08T10:53:05Z

@arschmitz Can this be closed as we have individual modules now?

arschmitz · 2016-05-12T18:12:30Z

Yes but lets open issues for any widgets which dont have an individual module test already i think there are still a acouple

Re jquery-archivegh-5987

Re gh-5987

gabrielschulhof pushed a commit that referenced this issue Sep 5, 2013

Unit tests: Individual modules: Add textinput test. Re: #5987.

561a024

gabrielschulhof pushed a commit that referenced this issue Sep 24, 2013

Unit tests: Individual modules: Adding button demo. Re: #5987.

8b644e3

gabrielschulhof pushed a commit that referenced this issue Nov 18, 2013

Unit tests: Individual modules: Adding button demo. Re: #5987.

0cfbe6b

gabrielschulhof pushed a commit that referenced this issue Apr 3, 2014

Checkboxradio: Test custom build scenario where widget is used alone

cf54c65

Re gh-5987 Re gh-7294

gabrielschulhof mentioned this issue Apr 3, 2014

Checkboxradio: Work outside the page and using custom build #7295

Closed

gabrielschulhof pushed a commit that referenced this issue Apr 24, 2014

Checkboxradio: Depend on vmouse and test custom, widget-only-build

dc3fa7d

Closes gh-7295 Fixes gh-7294 Re gh-5987

gabrielschulhof pushed a commit that referenced this issue Apr 24, 2014

Checkboxradio: Depend on vmouse and test custom, widget-only-build

26b1d16

(cherry picked from commit dc3fa7d) Closes gh-7295 Fixes gh-7294 Re gh-5987

gabrielschulhof pushed a commit that referenced this issue May 8, 2014

Slider: Add individual module test

8ec3d2a

Re gh-5987

gabrielschulhof mentioned this issue May 8, 2014

Slider: depend on vmouse #7384

Closed

gabrielschulhof pushed a commit that referenced this issue May 16, 2014

Table: Add individual-modules tests for reflow and columntoggle

d9c44a4

Re gh-5987

gabrielschulhof pushed a commit that referenced this issue May 25, 2014

Table: Add individual-modules tests for reflow and columntoggle

7332d24

Re gh-5987

gabrielschulhof mentioned this issue May 29, 2014

Events dependency #7274

Closed

jaspermdegroot added this to the 1.5.0 milestone May 30, 2014

jaspermdegroot added the Priority: High label May 30, 2014

arschmitz pushed a commit that referenced this issue Jun 2, 2014

Slider and Rangeslider: Express module dependency

44e2d98

Both modules have a hard dependency on the "vmouse" module that should be expressed in AMD. Re gh-5987 Closes gh-7383 Closes gh-7274

arschmitz pushed a commit that referenced this issue Jun 3, 2014

Slider and Rangeslider: Express module dependency

56dddc6

Both modules have a hard dependency on the "vmouse" module that should be expressed in AMD. Re gh-5987 Closes gh-7383 Closes gh-7274 (cherry picked from commit 44e2d98)

gabrielschulhof pushed a commit to gabrielschulhof/jquery-mobile that referenced this issue Jun 6, 2014

Table: Add individual-modules tests for reflow and columntoggle

3584877

Re jquery-archivegh-5987

gabrielschulhof pushed a commit that referenced this issue Jun 9, 2014

Table: Add individual-modules tests for reflow and columntoggle

05d910c

Re gh-5987

gabrielschulhof pushed a commit that referenced this issue Jun 17, 2014

Table: Add individual-modules tests for reflow and columntoggle

c362e0e

Re gh-5987

gabrielschulhof pushed a commit that referenced this issue Jun 19, 2014

Table: Add individual-modules tests for reflow and columntoggle

e5d1724

Re gh-5987

gabrielschulhof pushed a commit that referenced this issue Aug 28, 2014

Table: Add individual-modules tests for reflow and columntoggle

b74ac0f

Re gh-5987

gabrielschulhof pushed a commit that referenced this issue Aug 29, 2014

Table: Add individual-modules tests for reflow and columntoggle

c37b5e6

Re gh-5987

gabrielschulhof pushed a commit that referenced this issue Oct 9, 2014

Loader: Add individual unit test

bde66a3

Re gh-5987

arschmitz modified the milestones: 1.6.0, 1.5.0 Jun 29, 2015

cgack pushed a commit to cgack/jquery-mobile that referenced this issue Dec 10, 2015

Table: Add individual-modules tests for reflow and columntoggle

9c44da2

Re jquery-archivegh-5987

arschmitz pushed a commit to arschmitz/jquery-mobile that referenced this issue Mar 28, 2016

Table: Add individual-modules tests for reflow and columntoggle

6a6d06c

Re jquery-archivegh-5987

arschmitz pushed a commit that referenced this issue Mar 28, 2016

Table: Add individual-modules tests for reflow and columntoggle

39ed41f

Re gh-5987

arschmitz pushed a commit to arschmitz/jquery-mobile that referenced this issue Jul 4, 2016

Table: Add individual-modules tests for reflow and columntoggle

ebe4601

Re jquery-archivegh-5987

arschmitz pushed a commit that referenced this issue Jul 4, 2016

Table: Add individual-modules tests for reflow and columntoggle

27eeb09

Re gh-5987

apsdehal closed this as completed Jul 7, 2016

apsdehal self-assigned this Aug 2, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Write unit tests for single module support #5987

Write unit tests for single module support #5987

jzaefferer commented May 9, 2013

arschmitz commented May 10, 2013

Uh oh!

jaspermdegroot commented May 29, 2013

Uh oh!

jzaefferer commented Jul 4, 2013

Uh oh!

jaspermdegroot commented Jul 4, 2013

Uh oh!

jaspermdegroot commented Aug 13, 2013

Uh oh!

gabrielschulhof commented Aug 15, 2013

Uh oh!

gabrielschulhof commented Aug 15, 2013

Uh oh!

apsdehal commented May 8, 2016

Uh oh!

arschmitz commented May 12, 2016

Uh oh!

Write unit tests for single module support #5987

Write unit tests for single module support #5987

Comments

jzaefferer commented May 9, 2013

arschmitz commented May 10, 2013

Uh oh!

jaspermdegroot commented May 29, 2013

Uh oh!

jzaefferer commented Jul 4, 2013

Uh oh!

jaspermdegroot commented Jul 4, 2013

Uh oh!

jaspermdegroot commented Aug 13, 2013

Uh oh!

gabrielschulhof commented Aug 15, 2013

Uh oh!

gabrielschulhof commented Aug 15, 2013

Uh oh!

apsdehal commented May 8, 2016

Uh oh!

arschmitz commented May 12, 2016

Uh oh!